Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231490: Ugly racy writes to ZipUtils.defaultBuf #891

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 17, 2022

Clean backport to fix a minor data race.

Additional testing:

  • Linux x86_64 fastdebug, java/nio/zipfs, java/util/zip, java/util/jar

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/891/head:pull/891
$ git checkout pull/891

Update a local copy of the PR:
$ git checkout pull/891
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 891

View PR using the GUI difftool:
$ git pr show -t 891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/891.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 905e3e88137d46f90de7034e9fc324e97af873a6 8231490: Ugly racy writes to ZipUtils.defaultBuf Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8231490: Ugly racy writes to ZipUtils.defaultBuf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 365 new commits pushed to the master branch:

  • e6c2792: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
  • ff675cc: 8297000: [jib] Add more friendly warning for proxy issues
  • 9eeb741: 8295564: Norwegian Nynorsk Locale is missing formatting
  • e91b87e: 8294906: Memory leak in PKCS11 NSS TLS server
  • b0e142e: 8292755: Non-default method in interface leads to a stack overflow in JShell
  • 3aa85f9: 8287007: [cgroups] Consistently use stringStream throughout parsing code
  • fc03710: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
  • 2bf9828: 8245877: assert(_value != __null) failed: resolving NULL _value in JvmtiExport::post_compiled_method_load
  • f8408c7: 8305113: (tz) Update Timezone Data to 2023c
  • acbac0d: 8288589: Files.readString ignores encoding errors for UTF-16
  • ... and 355 more: https://git.openjdk.org/jdk17u-dev/compare/8ce7bb4ed8903384a85b348cfbe5a89b961ba53b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 12, 2023
@shipilev
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@shipilev This pull request is now open

@shipilev
Copy link
Member Author

Actually, I see no compelling reason to proceed with this in 17u at the moment. I am closing this PR and dropping the backport tags.

@shipilev shipilev closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant