Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 #896

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 18, 2022

Backport for JDK-8286624 Regression Test CoordinateTruncationBug.java fails on OL8.3

(cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283)

Clean backport. New test, low risk.
Test pass on manual run (mac, linux, x64 aarch64) using
make run-test TEST="test/jdk/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/896/head:pull/896
$ git checkout pull/896

Update a local copy of the PR:
$ git checkout pull/896
$ git pull https://git.openjdk.org/jdk17u-dev pull/896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 896

View PR using the GUI difftool:
$ git pr show -t 896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/896.diff

Reviewed-by: azvegint, kizune
(cherry picked from commit c71d87e54ca0c0173583bed978e06c7faa0fa283)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c71d87e54ca0c0173583bed978e06c7faa0fa283 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 728dc4d: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • 1c13d7e: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@Rudometov
Your change (at version 75e95f7) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit 5c80285.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 1bbe4c2: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • d0ad871: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
  • 94b9081: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 023f651: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • 8f4a3a5: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • 3f79952: 8278826: Print error if Shenandoah flags are empty (instead of crashing)
  • 112ea1d: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size
  • a167975: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 7a111ea: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()
  • 728dc4d: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/52103da08c931f1a4599fa191d8f1cc6ca74d9bd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@shipilev @Rudometov Pushed as commit 5c80285.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8286624 branch January 20, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants