New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293550: Optionally add get-task-allow entitlement to macos binaries #916
Conversation
👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
cf9bd01
to
b98a4e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing.
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8293550
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benty-amzn Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
I'm not sure why those conflicts appeared, after pulling the current |
@benty-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@benty-amzn |
/sponsor |
@phohensee @benty-amzn Pushed as commit da6fca4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting for parity with Oracle JDK 17. Patch is clean after JDK-8273497 (#914) and JDK-8285093 (#915).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/916/head:pull/916
$ git checkout pull/916
Update a local copy of the PR:
$ git checkout pull/916
$ git pull https://git.openjdk.org/jdk17u-dev pull/916/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 916
View PR using the GUI difftool:
$ git pr show -t 916
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/916.diff