Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270155: ARM32: Improve register dump in hs_err #926

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 23, 2022

Clean backport to improve ARM32 error handling.

Additional testing:

  • Linux ARM32 fastdebug make bootcycle-images
  • Ad-hoc Linux ARM32 fastdebug crashes, eyeballing hs-errs

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/926/head:pull/926
$ git checkout pull/926

Update a local copy of the PR:
$ git checkout pull/926
$ git pull https://git.openjdk.org/jdk17u-dev pull/926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 926

View PR using the GUI difftool:
$ git pr show -t 926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/926.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 589a1d53df0f53c064fda8a2ac491e0a536ea487 8270155: ARM32: Improve register dump in hs_err Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270155: ARM32: Improve register dump in hs_err

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4f5326c: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • 2f7e673: 8289301: P11Cipher should not throw out of bounds exception during padding
  • 4a9774a: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • 842edfe: 8274903: Zero: Support AsyncGetCallTrace
  • 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 14eb228: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines
  • 24ac347: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 5125320: 8283999: Update JMH devkit to 1.35

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit 615bf95.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 1743825: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
  • 4f5d847: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • c086725: 8282398: EndingDotHostname.java test fails because SSL cert expired
  • a596d64: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
  • 4f5326c: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • 2f7e673: 8289301: P11Cipher should not throw out of bounds exception during padding
  • 4a9774a: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • 842edfe: 8274903: Zero: Support AsyncGetCallTrace
  • 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/5c802851d4c8c36bb5551d8896a0a45b9cb83582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@shipilev Pushed as commit 615bf95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8270155-arm-hs-err branch January 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant