New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296715: CLDR v42 update for tzdata 2022f #942
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for backporting!
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
The change looks good to me, but I think this should be a critical request for openjdk/jdk17u instead, so it makes 17.0.6 which has 2022f (17u went into rampdown yesterday: https://mail.openjdk.org/pipermail/jdk-updates-dev/2022-November/019048.html). Note that Oracle have included this in their 17.0.6. Do you plan to handle 11u as well? |
I am preparing an 11u-dev PR as well. |
Great. Same thing, please aim for 11u so we can get this in with the tzdata 2022f change. |
https://wiki.openjdk.org/display/JDKUpdates/JDK+17u /integrate |
Going to push as commit 3df0e29.
Your commit was automatically rebased without conflicts. |
Great. Same thing, please aim for 11u so we can get this in with the tzdata 2022f change.
Ok this is strange. Why is 11u & 17u rampdown so late? 8u's was last week. |
backport of 8296715;
avoid make/data/cldr/common/dtd/ldmlSupplemental.dtd
changes like it has been done in the 19u and 15u backports; test files need manual adjustment because of changes in the stride
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/942/head:pull/942
$ git checkout pull/942
Update a local copy of the PR:
$ git checkout pull/942
$ git pull https://git.openjdk.org/jdk17u-dev pull/942/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 942
View PR using the GUI difftool:
$ git pr show -t 942
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/942.diff