Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296548: Improve MD5 intrinsic for x86_64 #954

Closed
wants to merge 1 commit into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented Dec 15, 2022

This is a clean backport to improve the performance of MD5 intrinsic.

The change has been tested with TestMD5Intrinsics and TestMD5MultiBlockIntrinsics (with the patch f43bb9f).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/954/head:pull/954
$ git checkout pull/954

Update a local copy of the PR:
$ git checkout pull/954
$ git pull https://git.openjdk.org/jdk17u-dev pull/954/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 954

View PR using the GUI difftool:
$ git pr show -t 954

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/954.diff

Reviewed-by: kvn, sviswanathan, luhenry
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2022

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@yftsai yftsai changed the title 8296548: Improve MD5 intrinsic for x86_64 Backport 6ead2b019595f9b54a70603da84f11271ee070b6 8296548: Improve MD5 intrinsic for x86_64 Dec 15, 2022
@yftsai yftsai changed the title Backport 6ead2b019595f9b54a70603da84f11271ee070b6 8296548: Improve MD5 intrinsic for x86_64 Backport 6ead2b019595f9b54a70603da84f11271ee070b6 Dec 15, 2022
@openjdk openjdk bot changed the title Backport 6ead2b019595f9b54a70603da84f11271ee070b6 8296548: Improve MD5 intrinsic for x86_64 Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@yftsai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296548: Improve MD5 intrinsic for x86_64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 11a53b7: Merge
  • 41c9d7d: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
  • 0ab310e: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR
  • 244d194: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • eb95804: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling
  • 8b0c5b9: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly
  • 9729dad: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
  • ade0edf: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion
  • 6262937: 8155246: Throw error if default java.security file is missing
  • e770114: 8288130: compiler error with AP and explicit record accessor
  • ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/9fdaa338b727353a259b09ed215117449829c5a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2022

Webrevs

@yftsai
Copy link
Contributor Author

yftsai commented Dec 28, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@yftsai
Your change (at version 592b657) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit 838ca6a.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 6042c6b: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • 219041d: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
  • c603f82: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
  • e33c871: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
  • 032f007: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • bcdaebf: 8298027: Remove SCCS id's from awt jtreg tests
  • 70f235d: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • 11a53b7: Merge
  • 41c9d7d: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
  • 0ab310e: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/9fdaa338b727353a259b09ed215117449829c5a1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@phohensee @yftsai Pushed as commit 838ca6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants