Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled #354

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 15, 2022

I backport this for parity with 17.0.5-oracle.

I had to resolve the change in a few places:

src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java
Where "true" is added to permits() call, code looks different. This is because
"8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key"
is not backported.
Added true to all calls of permits().

src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
Method permits() has a slightly different implementation in 17.
The new parameter is just switching off the check. I
wrapped the check around the code in 17 as in the original.

src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java
Copyright
Call to permits() has different argument.

It already ran successful through our nightly testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/354/head:pull/354
$ git checkout pull/354

Update a local copy of the PR:
$ git checkout pull/354
$ git pull https://git.openjdk.org/jdk17u pull/354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 354

View PR using the GUI difftool:
$ git pr show -t 354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/354.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03f8c0fb9363dc1bb07bed1ae0359c029caa0130 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled Sep 15, 2022
@openjdk
Copy link

openjdk bot commented Sep 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 15, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting!

@openjdk
Copy link

openjdk bot commented Sep 15, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

Pre-submit failure
macos: gent error: java.lang.Exception: Agent 31 timed out with a timeout of 480 seconds; in runtime/LoadClass/TestResize
x86: TestStringDeduplicationAgeThreshold.java#id1 known to be failing sporadically

Both unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit 6bc6980.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6f2bbc4: 8028265: Add legacy tz tests to OpenJDK

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@GoeLin GoeLin deleted the goetz_backport_8275887 branch September 16, 2022 07:15
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@GoeLin Pushed as commit 6bc6980.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants