Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297804: (tz) Update Timezone Data to 2022g #361

Closed

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 12, 2022

Clean backport of the latest tzdata update.

This pull request contains a backport of commit ce896731 from the openjdk/jdk repository.

The commit being backported was authored by Andrew John Hughes on 7 Dec 2022 and was reviewed by Naoto Sato.

Tests in java/util/TimeZone, java/time/test, sun/util/calendar, sun/util/resources and sun/text/resources all pass.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/361/head:pull/361
$ git checkout pull/361

Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.org/jdk17u pull/361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 361

View PR using the GUI difftool:
$ git pr show -t 361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/361.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce896731d38866c2bf99cd49525062e150d94160 8297804: (tz) Update Timezone Data to 2022g Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 12, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly the PR bot does not recognize the backport as clean. Seems like some files have been moved between head and here which was no issue for the /backport command on the commit in head. Nevermind, I eyeballed it and it looks correct.

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297804: (tz) Update Timezone Data to 2022g

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2022
@gnu-andrew
Copy link
Member Author

Interestingly the PR bot does not recognize the backport as clean. Seems like some files have been moved between head and here which was no issue for the /backport command on the commit in head. Nevermind, I eyeballed it and it looks correct.

Strange. The /backport command seems to have handled both 17u & 11u fine. Thanks for the review.

I've already flagged this with jdk17u-critical-request if you'd like to approve.

@gnu-andrew
Copy link
Member Author

/clean

@openjdk openjdk bot added the clean label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@gnu-andrew This backport pull request is now marked as clean

@RealCLanger
Copy link
Contributor

I've already flagged this with jdk17u-critical-request if you'd like to approve.

Done.

@gnu-andrew
Copy link
Member Author

Thanks.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

Going to push as commit 12f32df.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2022
@openjdk openjdk bot closed this Dec 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@gnu-andrew Pushed as commit 12f32df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants