Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298527: Cygwin's uname -m returns different string than before #362

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 14, 2022

Needed to resolve due to missing change for RISCV support.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298527: Cygwin's uname -m returns different string than before

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/362/head:pull/362
$ git checkout pull/362

Update a local copy of the PR:
$ git checkout pull/362
$ git pull https://git.openjdk.org/jdk17u pull/362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 362

View PR using the GUI difftool:
$ git pr show -t 362

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/362.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 51f0a1ce4b0d72cf7e82e01f7014274d8b7d1575 8298527: Cygwin's uname -m returns different string than before Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

not urgent as latest cygwin fixed the output again. We can backport this to jdk17u-dev.

@RealCLanger RealCLanger deleted the RealCLanger-backport-51f0a1ce branch December 20, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant