-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR #363
Conversation
… signed JAR Reviewed-by: weijun, hchao
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger Could you please review this? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 0ab310e. |
Clean backport (modulo copyright header in
DisabledAlgorithmConstraints
) fixing a regression introduced with JDK-8269039: Disable SHA-1 Signed JARs which was included in 17.0.5. This should be low-risk as it mainly removes use ofjava.util.Calendar
API usage inDisabledAlgorithmConstraints
which can cause issues with applications that containCalendarDataProvider
s in signed jars. See JDK-8297684 for details.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/363/head:pull/363
$ git checkout pull/363
Update a local copy of the PR:
$ git checkout pull/363
$ git pull https://git.openjdk.org/jdk17u pull/363/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 363
View PR using the GUI difftool:
$ git pr show -t 363
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/363.diff