This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here is a backport of 8287894 that fixes reproducible debug build for Windows. The original patch applied cleanly.
Verification (Windows10/MSVS2019):
bash ./configure --with-boot-jdk=c:/work/boot-jdk/jdk-18 --with-debug-level=fastdebug --with-hotspot-build-time="6/7/2022 2:35pm" --with-extra-cflags="/experimental:deterministic"
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk18u pull/151/head:pull/151
$ git checkout pull/151
Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jdk18u pull/151/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 151
View PR using the GUI difftool:
$ git pr show -t 151
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk18u/pull/151.diff