Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8283457: [macos] libpng build failures with Xcode13.3 #174

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 21, 2022

Hi all,
This pull request contains a backport of commit 33eb89df from the openjdk/jdk repository.
The commit being backported was authored by Phil Race on 22 Mar 2022 and was reviewed by Erik Joelsson.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283457: [macos] libpng build failures with Xcode13.3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk18u pull/174/head:pull/174
$ git checkout pull/174

Update a local copy of the PR:
$ git checkout pull/174
$ git pull https://git.openjdk.org/jdk18u pull/174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 174

View PR using the GUI difftool:
$ git pr show -t 174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk18u/pull/174.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 33eb89dfeb4a43e1ad2c3dd657ec3b6ee7abbb3a 8283457: [macos] libpng build failures with Xcode13.3 Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283457: [macos] libpng build failures with Xcode13.3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@mrserb mrserb marked this pull request as ready for review June 21, 2022 21:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2022

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant