Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Commit

Permalink
8289183: jdk.jfr.consumer.RecordedThread.getId references Thread::get…
Browse files Browse the repository at this point in the history
…Id, should be Thread::threadId

Reviewed-by: alanb
  • Loading branch information
egahlin committed Jul 3, 2022
1 parent c4dcce4 commit dc4edd3
Showing 1 changed file with 7 additions and 2 deletions.
Expand Up @@ -54,7 +54,7 @@ public String getOSName() {
/**
* Returns the thread ID used by the operating system.
*
* @return The Java thread ID, or {@code -1} if doesn't exist
* @return the OS thread ID, or {@code -1} if doesn't exist
*/
public long getOSThreadId() {
Long l = getTyped("osThreadId", Long.class, -1L);
Expand Down Expand Up @@ -86,6 +86,8 @@ public String getJavaName() {
* Returns the Java thread ID, or {@code -1} if it's not a Java thread.
*
* @return the Java thread ID, or {@code -1} if it's not a Java thread
*
* @see java.lang.Thread#threadId()
*/
public long getJavaThreadId() {
Long l = getTyped("javaThreadId", Long.class, -1L);
Expand All @@ -97,7 +99,10 @@ public long getJavaThreadId() {
* reused within the lifespan of the JVM.
* <p>
* See {@link #getJavaThreadId()} for the ID that is returned by
* {@code java.lang.Thread.getId()}
* {@code java.lang.Thread.threadId()}.
* <p>
* See {@link #getOSThreadId()} for the ID that is returned by
* the operating system.
*
* @return a unique ID for the thread
*/
Expand Down

1 comment on commit dc4edd3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.