Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl #106

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 4, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.org/jdk19 pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/106.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a8edd7a12f955fe843c7c9ad4273e9c653a80c5a 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1a27164: 8287851: C2 crash: assert(t->meet(t0) == t) failed: Not monotonic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing it to jdk19.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

Going to push as commit 0dff327.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1a27164: 8287851: C2 crash: assert(t->meet(t0) == t) failed: Not monotonic

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2022
@openjdk openjdk bot closed this Jul 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@MBaesken Pushed as commit 0dff327.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants