Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8289872: wrong wording in @param doc for HashMap.newHashMap et. al. #118

Closed
wants to merge 1 commit into from
Closed

8289872: wrong wording in @param doc for HashMap.newHashMap et. al. #118

wants to merge 1 commit into from

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jul 7, 2022

Minor doc wording changes, to be consistent with HashSet.newHashSet et. al.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.org/jdk19 pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/118.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2022

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2022

Webrevs

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289872: wrong wording in @param doc for HashMap.newHashMap et. al.

Reviewed-by: chegar, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 1304390: 8289951: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java on linux-x64 and macosx-x64
  • 11319c2: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out
  • 3212dc9: 8289486: Improve XSLT XPath operators count efficiency
  • a8eb728: 8289779: Map::replaceAll javadoc has redundant @throws clauses
  • 889150b: 8289558: Need spec clarification of j.l.foreign.*Layout
  • 8dd94a2: 8289196: Pattern domination not working properly for record patterns
  • 8f24d25: 6509045: {@inheritdoc} only copies one instance of the specified exception
  • 9a0fa82: 8288949: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing
  • 55fa19b: 8289857: ProblemList jdk/jfr/event/runtime/TestActiveSettingEvent.java
  • 32b650c: 8289840: ProblemList vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java when run with vthread wrapper
  • ... and 3 more: https://git.openjdk.org/jdk19/compare/0b6fd4820c1f98d6154d7182345273a4c9468af5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2022
@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2022

Going to push as commit eeaf0bb.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 460d879: 8289601: SegmentAllocator::allocateUtf8String(String str) should be clarified for strings containing \0
  • 732f106: 8289223: Canonicalize header ids in foreign API javadocs
  • ea21c46: 8289799: Build warning in methodData.cpp memset zero-length parameter
  • 6428607: 8289030: [macos] app image signature invalid when creating DMG or PKG
  • 1304390: 8289951: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java on linux-x64 and macosx-x64
  • 11319c2: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out
  • 3212dc9: 8289486: Improve XSLT XPath operators count efficiency
  • a8eb728: 8289779: Map::replaceAll javadoc has redundant @throws clauses
  • 889150b: 8289558: Need spec clarification of j.l.foreign.*Layout
  • 8dd94a2: 8289196: Pattern domination not working properly for record patterns
  • ... and 7 more: https://git.openjdk.org/jdk19/compare/0b6fd4820c1f98d6154d7182345273a4c9468af5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2022
@openjdk openjdk bot closed this Jul 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2022
@openjdk
Copy link

openjdk bot commented Jul 8, 2022

@stuart-marks Pushed as commit eeaf0bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants