8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

[VladimirKempik]

Clean backport to jdk19

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jdk19 pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/125.diff

[bridgekeeper]

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@VladimirKempik The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (395f4733)

[VladimirKempik]

As far as I understand, between rdp1 and rdp2 dates I need no approval for p3 bug

[VladimirKempik]

/integrate

[openjdk]

Going to push as commit c142fbb.

[openjdk]

@VladimirKempik Pushed as commit c142fbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[prrace]

As far as I understand, between rdp1 and rdp2 dates I need no approval for p3 bug

HOWEVER, if you intend a fix for JDK N after RDP1 then the PR for review should be against JDK N - NOT mainline.
JDK N (ie 19) fixes are forward ported to mainline - not the way round you did it.
Also there is a HIGH burden on YOU to test it THOROUGHLY.
So what you did is exploit the skara clean backport rules in a way that they aren't intended for.

[VladimirKempik]

Sorry. that wasn't clear from the jep text:
https://openjdk.org/jeps/3
If the bug is current then develop a fix and either integrate it when ready (in RDP 1) or request approval to integrate it via the fix-request process (RDP 2 and RC). In RDP 1, if the bug is targeted and if time permits, develop and integrate a fix when ready.

So what you did is exploit the skara clean backport rules in a way that they aren't intended for.

unintentionally