Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large #163

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link

@vnkozlov vnkozlov commented Aug 12, 2022

Regressions have been observed with the 11.0.16 and following releases. See JDK-8291665 and JDK-8288184. There might be more code-shapes out in the wild which trigger similar issues. Therefore we'd like to back out the patch of JDK-8279219. Risk is obviously that the fix of JDK-8279219 would no longer be there and potential other issues caused by the absence of JDK-8279219 (that we don't know yet). Yet it gets us back to where we were before JDK-8279219. It seems the safest option moving forward.

Backout is not clean because of additional changes in graphKit.cpp and test TestFailedAllocationBadGraph.java.

I verified changes with test case from JDK-8288184.

Passed tier1-5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk19 pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/163.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 12, 2022
@vnkozlov vnkozlov marked this pull request as ready for review August 12, 2022 17:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

Copy link

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
@vnkozlov
Copy link
Author

Thank you, Vladimir.

@vnkozlov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

Going to push as commit 967a28c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2022
@openjdk openjdk bot closed this Aug 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@vnkozlov Pushed as commit 967a28c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8292260 branch August 12, 2022 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants