8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large #163
Conversation
👋 Welcome back kvn! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@vnkozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thank you, Vladimir. |
/integrate |
Going to push as commit 967a28c. |
Regressions have been observed with the 11.0.16 and following releases. See JDK-8291665 and JDK-8288184. There might be more code-shapes out in the wild which trigger similar issues. Therefore we'd like to back out the patch of JDK-8279219. Risk is obviously that the fix of JDK-8279219 would no longer be there and potential other issues caused by the absence of JDK-8279219 (that we don't know yet). Yet it gets us back to where we were before JDK-8279219. It seems the safest option moving forward.
Backout is not clean because of additional changes in graphKit.cpp and test TestFailedAllocationBadGraph.java.
I verified changes with test case from JDK-8288184.
Passed tier1-5.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/163/head:pull/163
$ git checkout pull/163
Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.org/jdk19 pull/163/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 163
View PR using the GUI difftool:
$ git pr show -t 163
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/163.diff