Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8287401: jpackage tests failing on Windows due to powershell issue #26

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Jun 16, 2022

Run a script extracting icons from executables as PowerShell command line rather than a script


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287401: jpackage tests failing on Windows due to powershell issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/26/head:pull/26
$ git checkout pull/26

Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/jdk19 pull/26/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26

View PR using the GUI difftool:
$ git pr show -t 26

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/26.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287401: jpackage tests failing on Windows due to powershell issue

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
  • 729164f: 8288533: Missing @param tags in com.sun.source classes
  • 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
  • 395aea3: 8288414: Long::compress/expand samples are not correct
  • f3b1f60: 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
  • 31bc689: 8288324: Loom: Uninitialized JvmtiEnvs in VM_Virtual* ops

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2022
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

Going to push as commit c254c9d.
Since your change was applied there have been 6 commits pushed to the master branch:

  • ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
  • 729164f: 8288533: Missing @param tags in com.sun.source classes
  • 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
  • 395aea3: 8288414: Long::compress/expand samples are not correct
  • f3b1f60: 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
  • 31bc689: 8288324: Loom: Uninitialized JvmtiEnvs in VM_Virtual* ops

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2022
@openjdk openjdk bot closed this Jun 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@alexeysemenyukoracle Pushed as commit c254c9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants