This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
8286836: Crash in GetSetLocalTest: No support for deferred values in continuations #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVMTI
SetLocalXXX
requires the target virtual thread suspended at a breakpoint or single step event.This is the relevant statement from the
"Local Variable"
section:The SetLocalXXX functions may be used to set the value of a local variable in the topmost frame of a virtual thread suspended at a breakpoint or single step event.
This fix is to return the JVMTI_ERROR_OPAQUE_FRAME in cases when the target thread is not at a breakpoint or single step event. In this case the assert described in the bug report is avoided:
Also, this is an analysis from Ron:
Changes GetSetLocalTest test are taken from the repo-loom repository. It was an update from Leonid which is needed to reproduce this problem.
The fix was tested with thousands of runs of the GetSetLocalTest on Linux, Windows and MacOs.
Will also submit nsk.jvmti and nsk.jdi test runs on mach5.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/41/head:pull/41
$ git checkout pull/41
Update a local copy of the PR:
$ git checkout pull/41
$ git pull https://git.openjdk.org/jdk19 pull/41/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 41
View PR using the GUI difftool:
$ git pr show -t 41
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/41.diff