This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
8288741: JFR: Change package name of snippet files #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could I have a review of PR that changes package names of the JFR snippet files. Today they are named "example1" and "example2" in the default package. It looks strange when browsing classes in jrt-fs.jar, for example in Eclipse. Not sure why they are included at all. New names will be "jdk.jfr.snippets" and "jdk.jfr.snippets.consumer"
Testing: build docs + tier1 + tier2
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/46/head:pull/46
$ git checkout pull/46
Update a local copy of the PR:
$ git checkout pull/46
$ git pull https://git.openjdk.org/jdk19 pull/46/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 46
View PR using the GUI difftool:
$ git pr show -t 46
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/46.diff