-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
👋 Welcome back joehw! A progress list of the required criteria for merging this PR into |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@JoeWang-Java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 9e2d9ac.
Your commit was automatically rebased without conflicts. |
@JoeWang-Java Pushed as commit 9e2d9ac. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some of the links cause redirection, iso.org in particular took 1-2 seconds, that looks like was longer than the wait time of the doccheck and docs link checker. Changed it to the current homepage to avoid redirection. Also changed other links within this package.
I'm limiting the change to this package only as iso.org only appears in it and other redirections have not caused any issue (tests showed they were almost instant).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/55/head:pull/55
$ git checkout pull/55
Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.org/jdk19 pull/55/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 55
View PR using the GUI difftool:
$ git pr show -t 55
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/55.diff