Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only" #57

Closed
wants to merge 3 commits into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Jun 22, 2022

Greetings,

this is a small adjustment to rectify the consequence of JDK-8288663.

Testing: jdk_jfr

Thanks
Markus


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/57/head:pull/57
$ git checkout pull/57

Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk19 pull/57/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 57

View PR using the GUI difftool:
$ git pr show -t 57

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/57.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2022
@mgronlun
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

Going to push as commit 6037ccd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2022
@openjdk openjdk bot closed this Jun 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@mgronlun Pushed as commit 6037ccd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants