8289093: BlockLocationPrinter fails to decode addresses with G1 #68
8289093: BlockLocationPrinter fails to decode addresses with G1 #68
Conversation
…ck_start instead of crashing
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
Webrevs
|
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks @albertnetymk @walulyai for your reviews. /integrate |
Going to push as commit 699ad45.
Your commit was automatically rebased without conflicts. |
Hi all,
can I have reviews for this change that fixes an assertion failure when trying to add annotations to the hs_err file?
The
block_start
API fromCollectedHeap
assumes that useful values for all given addresses is returned, not asserting/crashing like some method deeper in the call chain does since JDK-8270540, resulting in somewhat scrambled hs_err files and additional stack frames to look at in the debugger.Testing: local compilation, gha, tier1-3
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/68/head:pull/68
$ git checkout pull/68
Update a local copy of the PR:
$ git checkout pull/68
$ git pull https://git.openjdk.org/jdk19 pull/68/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 68
View PR using the GUI difftool:
$ git pr show -t 68
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/68.diff