Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode #78

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 27, 2022

A trivial fix to ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.org/jdk19 pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/78.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 27, 2022 18:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2022
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode

Reviewed-by: bpb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2022
@dcubed-ojdk
Copy link
Member Author

@bplb and @naotoj - Thanks for the fast reviews!

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit caa6b74.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 28913f4: 8289235: ProblemList vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011/TestDescription.java when run with vthread wrapper

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@dcubed-ojdk Pushed as commit caa6b74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8289240 branch June 27, 2022 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants