Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8291508: Fix some tests with "requires vm.jvmti & vm.continuations" #14

Closed

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Aug 24, 2022

I would like to backport this test fix. Low risk, only test changes. Clean backport. The changed tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291508: Fix some tests with "requires vm.jvmti & vm.continuations"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk19u pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/14.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2022

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0cc49fd9eac5259543a3c41b7a32b6e01a1b0ad5 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291508: Fix some tests with "requires vm.jvmti & vm.continuations"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d10e902: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
  • 8934a84: 8227651: Tests fail with SSLProtocolException: Input record too big

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2022

Webrevs

@theaoqi
Copy link
Member Author

theaoqi commented Aug 29, 2022

Got the jdk19u-fix-yes.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 29, 2022
@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@theaoqi
Your change (at version cff510a) is now ready to be sponsored by a Committer.

@theaoqi
Copy link
Member Author

theaoqi commented Sep 9, 2022

Could someone help to sponsor?

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

Going to push as commit 7f34799.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 59a331a: 8290496: riscv: Fix build warnings-as-errors with GCC 11
  • 30294b3: 8286314: Trampoline not created for far runtime targets outside small CodeCache
  • d0b021b: 8288992: AArch64: CMN should be handled the same way as CMP
  • e6bd2c9: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 27158f2: 8290451: Incorrect result when switching to C2 OSR compilation from C1
  • 83cb884: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
  • 63c53da: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 6b9fe5d: 8293044: C1: Missing access check on non-accessible class
  • e8a134a: 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region
  • a8ca05c: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • ... and 14 more: https://git.openjdk.org/jdk19u/compare/030ff3ad576776c008b7c962e3b1fd2c37735026...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2022
@openjdk openjdk bot closed this Sep 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@RealFYang @theaoqi Pushed as commit 7f34799.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi
Copy link
Member Author

theaoqi commented Sep 27, 2022

@RealFYang , thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants