Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8292159: TYPE_USE annotations on generic type arguments of record components discarded #62

Closed
wants to merge 1 commit into from

Conversation

sadayapalam
Copy link

@sadayapalam sadayapalam commented Nov 7, 2022

Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292159: TYPE_USE annotations on generic type arguments of record components discarded

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/62/head:pull/62
$ git checkout pull/62

Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.org/jdk19u pull/62/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 62

View PR using the GUI difftool:
$ git pr show -t 62

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/62.diff

…ponents discarded

    Backport-of: 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2022

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2022

Webrevs

Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sadayapalam sadayapalam changed the title 8296021: TYPE_USE annotations on generic type arguments of record components discarded 8292159: TYPE_USE annotations on generic type arguments of record components discarded Nov 7, 2022
@sadayapalam sadayapalam changed the title 8292159: TYPE_USE annotations on generic type arguments of record components discarded Backport 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292159: TYPE_USE annotations on generic type arguments of record components discarded

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2022
@openjdk openjdk bot changed the title Backport 4d9a1cd26fa0cda902aafcccd6e02bd7bc60bbb3 8292159: TYPE_USE annotations on generic type arguments of record components discarded Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

This backport pull request has now been updated with issue from the original commit.

@sadayapalam
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit c6e1849.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@sadayapalam Pushed as commit c6e1849.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sadayapalam sadayapalam deleted the JDK-8296021 branch November 7, 2022 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants