Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop #86

Closed

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Nov 22, 2022

Backport of JDK-8293996. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/86/head:pull/86
$ git checkout pull/86

Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.org/jdk19u pull/86/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 86

View PR using the GUI difftool:
$ git pr show -t 86

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/86.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dd51f7e0b75d3a16403608d89cd206ac0bedf882 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 62db7bb.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c8082a3: 8296771: RISC-V: C2: assert(false) failed: bad AD file
  • 2adc3e1: 8295414: [Aarch64] C2: assert(false) failed: bad AD file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@TobiHartmann Pushed as commit 62db7bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants