Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8295447: NullPointerException with invalid pattern matching construct in constructor call #99

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 29, 2022

Backport for JDK-8295447 NullPointerException with invalid pattern matching construct in constructor call

https://git.openjdk.org/jdk/commit/6c05771b9be3dd5cbcdb40d2e53cc53959926cdd

Clean backport
JTreg tier1, tier2, jck runtime and jck compiler passed.
Test T8295447.java passes during run.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295447: NullPointerException with invalid pattern matching construct in constructor call

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19u pull/99/head:pull/99
$ git checkout pull/99

Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.org/jdk19u pull/99/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 99

View PR using the GUI difftool:
$ git pr show -t 99

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19u/pull/99.diff

… in constructor call

Reviewed-by: vromero
(cherry picked from commit 6c05771b9be3dd5cbcdb40d2e53cc53959926cdd)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6c05771b9be3dd5cbcdb40d2e53cc53959926cdd 8295447: NullPointerException with invalid pattern matching construct in constructor call Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295447: NullPointerException with invalid pattern matching construct in constructor call

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d153a8c: 8297309: Memory leak in ShenandoahFullGC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@Rudometov
Your change (at version 3bee01d) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Dec 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit c9d4857.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7275da4: 8296904: Improve handling of macos xcode toolchain
  • d153a8c: 8297309: Memory leak in ShenandoahFullGC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb @Rudometov Pushed as commit c9d4857.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
3 participants