Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64 #1

Closed
wants to merge 4 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 8, 2022

A trivial fix for several ProblemListings:
JDK-8298402 ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64
JDK-8298414 ProblemList gc/TestFullGCCount.java on linux-x64
JDK-8298417 ProblemList vmTestbase/nsk/stress/strace/strace004.java on 2 platforms
JDK-8298419 ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi005/TestDescription.java on windows-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64
  • JDK-8298414: ProblemList gc/TestFullGCCount.java on linux-x64
  • JDK-8298417: ProblemList vmTestbase/nsk/stress/strace/strace004.java on 2 platforms
  • JDK-8298419: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi005/TestDescription.java on windows-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/1/head:pull/1
$ git checkout pull/1

Update a local copy of the PR:
$ git checkout pull/1
$ git pull https://git.openjdk.org/jdk20 pull/1/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1

View PR using the GUI difftool:
$ git pr show -t 1

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/1.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dcubed-ojdk
Copy link
Member Author

/issue add JDK-8298402
/issue add JDK-8298414
/issue add JDK-8298417
/issue add JDK-8298419

/label add hotspot-runtime
/label add client
/label add hotspot-gc
/label add serviceability

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 8, 2022 20:03
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298414: ProblemList gc/TestFullGCCount.java on linux-x64.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298417: ProblemList vmTestbase/nsk/stress/strace/strace004.java on 2 platforms.

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8298419: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi005/TestDescription.java on windows-x64.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 8, 2022

Webrevs

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298402: ProblemList javax/swing/JFileChooser/4847375/bug4847375.java on windows-x64
8298414: ProblemList gc/TestFullGCCount.java on linux-x64
8298417: ProblemList vmTestbase/nsk/stress/strace/strace004.java on 2 platforms
8298419: ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi005/TestDescription.java on windows-x64

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2022
@dcubed-ojdk
Copy link
Member Author

@RogerRiggs - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

Going to push as commit 553ba65.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2022
@openjdk openjdk bot closed this Dec 8, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 8, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@dcubed-ojdk Pushed as commit 553ba65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8298402 branch December 9, 2022 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client client-libs-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants