8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."

[kimbarrett]

Please review this change to the gc/TestFullGCCount.java test to account for
the changes in JDK-8297247. The test was not updated by that change to
account for the new separation by G1 of STW full gc counts from concurrent
cycle counts in the GarbageCollectorMXBean.

To address this, the test has been changed to not be run if using G1 and
-XX:+ExplicitGCInvokesConcurrent.

Testing:
Verified the unmodified test fails when using G1 and +ExplicitGCInvokesConcurrent.
After updating the test, ran it with G1 selected and both with and without
ExplicitGCInvokesConcurrent. With now suppresses the test, without runs it
successfully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk20 pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/16.diff

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b5cbfcea)

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
• d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
• 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
• 0267aa5: 8297288: Example code in Scanner class
• cf93933: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Thanks for reviews @tschatzl and @albertnetymk .

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 2791701.
Since your change was applied there have been 12 commits pushed to the master branch:

• 0bbc418: 8294902: Undefined Behavior in C2 regalloc with null references
• 9bcdfc4: 8298425: System.console().readLine() hangs in jshell
• 27d4971: 8298520: C2: assert(found_opaque == res) failed: wrong pattern
• 51f0a1c: 8298527: Cygwin's uname -m returns different string than before
• 61ab16f: 8298700: Typo in DocTree comment
• c6f22b4: 8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
• bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())
• 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
• d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
• 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
• ... and 2 more: https://git.openjdk.org/jdk20/compare/d624debe23f60d778d7be43f28d06e9454057217...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 2791701.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.