Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) #19

Conversation

bchristi-git
Copy link
Member

@bchristi-git bchristi-git commented Dec 12, 2022

Backport 8295857 to jdk20


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk20 pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/19.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back bchristi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c7aca73177339f931f7dfb6627365548a32874f7 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt()) Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@bchristi-git This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@bchristi-git The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 12, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2022

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear to be identical to those in JDK 21.

@bchristi-git
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

Going to push as commit bf78f71.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
  • d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
  • 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2022
@openjdk openjdk bot closed this Dec 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@bchristi-git Pushed as commit bf78f71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants