Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8298050: Add links to graph output for javadoc #23

Closed
wants to merge 2 commits into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Dec 13, 2022

This PR proposes adding hyperlinks to the sealed graphic layout making navigation much simpler via the image.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jdk20 pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/23.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@minborg The following labels will be automatically applied to this pull request:

  • build
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org build build-dev@openjdk.org labels Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298050: Add links to graph output for javadoc

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 61ab16f: 8298700: Typo in DocTree comment
  • c6f22b4: 8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
  • bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2022
@minborg
Copy link
Contributor Author

minborg commented Dec 14, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@minborg
Your change (at version b4e0ce0) is now ready to be sponsored by a Committer.

@jddarcy
Copy link
Member

jddarcy commented Dec 15, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

Going to push as commit 2c42499.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 48f6127: 8298376: ZGC: thaws stackChunk with stale oops
  • 22a6b59: 8298727: Trees.getPath may crash for unnamed package
  • 323e574: 8298371: monitors_on_stack extracts unprocessed oops
  • 80cadd4: 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: null' for expression vm.opt.ExplicitGCInvokesConcurrent'"
  • ebc4710: 8298277: Replace "session" with "scope" for FFM access
  • 581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
  • 0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
  • 2791701: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."
  • 0bbc418: 8294902: Undefined Behavior in C2 regalloc with null references
  • 9bcdfc4: 8298425: System.console().readLine() hangs in jshell
  • ... and 5 more: https://git.openjdk.org/jdk20/compare/04b8d0cf5c964e16c583b66d9ab43a8c9a85fd72...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2022
@openjdk openjdk bot closed this Dec 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@jddarcy @minborg Pushed as commit 2c42499.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build build-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants