Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

JDK-8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive #27

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 13, 2022

Please review this spec clarification and its companion CSR https://bugs.openjdk.org/browse/JDK-8298698


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive
  • JDK-8298698: Clarify that javax.lang.model.util.Elements.overrides is irreflexive (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jdk20 pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/27.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added compiler compiler-dev@openjdk.org csr Pull request needs approved CSR before integration labels Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297305: Clarify that javax.lang.model.util.Elements.overrides is irreflexive

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Dec 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

Going to push as commit c6f22b4.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bf78f71: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2022
@openjdk openjdk bot closed this Dec 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@jddarcy Pushed as commit c6f22b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants