8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 #50
Conversation
/label add hotspot-runtime |
/issue JDK-8298976 |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk |
@dcubed-ojdk |
@dcubed-ojdk This issue is referenced in the PR title - it will now be updated. |
@dcubed-ojdk |
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@kimbarrett - Thanks for the fast review! /integrate |
@dcubed-ojdk Pushed as commit 0ecad28. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@irisclark - Thanks for the review! You may not be listed on the integration |
Instead of excluding java/util/concurrent/ExecutorService/CloseTest.java, we can just comment out the line in the test's DataProvider that produces a ForkJoinPool. That will allow the t test to exercise the other implementations until ForkJoinPool shutdown issue is fixed. |
@AlanBateman - It's only ProblemListed on one platform... |
A batch a trivial fixes to ProblemList tests:
JDK-8298976 ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
JDK-8298977 ProblemList vmTestbase/nsk/stress/strace/strace002.java on 2 platforms
JDK-8298978 ProblemList vmTestbase/nsk/stress/strace/strace003.java on 2 platforms
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/50/head:pull/50
$ git checkout pull/50
Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk20 pull/50/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 50
View PR using the GUI difftool:
$ git pr show -t 50
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/50.diff