Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

8299090: Specify coordinate order for additional CaptureCallState parameters on class as well #95

Closed
wants to merge 3 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jan 11, 2023

A small doc clarification that also specifies where the additional MemorySegment parameter of a downcall method handle linked with the captureCallState option appears in the parameter list, on the CaptureCallState class.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8299090: Specify coordinate order for additional CaptureCallState parameters on class as well
  • JDK-8299923: Specify coordinate order for additional CaptureCallState parameters on class as well (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20 pull/95/head:pull/95
$ git checkout pull/95

Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.org/jdk20 pull/95/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 95

View PR using the GUI difftool:
$ git pr show -t 95

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20/pull/95.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 11, 2023
@JornVernee JornVernee marked this pull request as ready for review January 11, 2023 02:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

Copy link
Contributor

@minborg minborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JornVernee
Copy link
Member Author

Thanks for the reviews, could you review the CSR as well?

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299090: Specify coordinate order for additional CaptureCallState parameters on class as well

Reviewed-by: pminborg, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 945ef07: 8299862: OfAddress setter should disallow heap segments
  • 636976a: 8299849: Revert JDK-8294461: wrong effectively final determination by javac
  • 0abb87a: 8299227: host exif.org not found in link in doc comment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 11, 2023
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

Going to push as commit 3918f9f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 945ef07: 8299862: OfAddress setter should disallow heap segments
  • 636976a: 8299849: Revert JDK-8294461: wrong effectively final determination by javac
  • 0abb87a: 8299227: host exif.org not found in link in doc comment

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2023
@openjdk openjdk bot closed this Jan 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@JornVernee Pushed as commit 3918f9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants