Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError #22

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 21, 2023

Hi all,
This pull request contains a backport of commit 78b1686c from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Jan 2023 and was reviewed by Alexey Ivanov and Tejesh R.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.org/jdk20u.git pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/22.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 78b1686c150aeaa29c5d969b70c9c42c872246a2 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review March 22, 2023 21:58
@openjdk
Copy link

openjdk bot commented Mar 22, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 59a3f4f: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Mar 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2023

Going to push as commit ad97686.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 59a3f4f: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2023
@openjdk openjdk bot closed this Mar 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2023
@openjdk
Copy link

openjdk bot commented Mar 24, 2023

@mrserb Pushed as commit ad97686.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant