8285523: Improve test java/io/FileOutputStream/OpenNUL.java #10
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-f42631e3
git fetch https://git.openjdk.org/jdk7u master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bae) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit c05358d. |
@bae @omikhaltsova Pushed as commit c05358d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8285523 to jdk7u.
The patch applied not cleanly due to the directory structure differences:
test/jdk/java/io/FileOutputStream/OpenNUL.java
->jdk/test/java/io/FileOutputStream/OpenNUL.java
Tested manually as follow:
$JTREG_HOME/bin/jtreg -jdk:$BUILD_HOME /cygdrive/c/projects/jdk7u-fork/jdk/test/java/io/
No regression in the above tests' group.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk7u pull/10/head:pull/10
$ git checkout pull/10
Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk7u pull/10/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10
View PR using the GUI difftool:
$ git pr show -t 10
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk7u/pull/10.diff