New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8209052: Low contrast in docs/api/constant-values.html #114
Conversation
👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@gnu-andrew Could you please review this backport. Thank you. |
@theRealAph Could you please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This backport has quite a few more changes to stylesheet.cs than the original commit. Is there another issue to backport first?
Also, please configure pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing.
@psoujany This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@psoujany This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/114/head:pull/114
$ git checkout pull/114
Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.org/jdk8u-dev pull/114/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 114
View PR using the GUI difftool:
$ git pr show -t 114
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/114.diff