Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209052: Low contrast in docs/api/constant-values.html #114

Closed
wants to merge 4 commits into from

Conversation

psoujany
Copy link

@psoujany psoujany commented Aug 25, 2022

Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 to JDK8.
Openjdk bug: https://bugs.openjdk.org/browse/JDK-8209052


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8209052: Low contrast in docs/api/constant-values.html

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/114/head:pull/114
$ git checkout pull/114

Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.org/jdk8u-dev pull/114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 114

View PR using the GUI difftool:
$ git pr show -t 114

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/114.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2022

👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e2eab3c1b7d55860e705ae6f924a2a3976f76f48 8209052: Low contrast in docs/api/constant-values.html Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 25, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2022

Webrevs

@psoujany
Copy link
Author

psoujany commented Sep 7, 2022

@gnu-andrew Could you please review this backport. Thank you.

@psoujany
Copy link
Author

psoujany commented Oct 4, 2022

@theRealAph Could you please review this PR.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport has quite a few more changes to stylesheet.cs than the original commit. Is there another issue to backport first?

Also, please configure pre-submit testing on your repo, see https://wiki.openjdk.org/display/SKARA/Testing.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

@psoujany This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2023

@psoujany This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants