Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox #132

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 10, 2022

Hi all,
This pull request contains a backport of commit ebfa27b9 from the openjdk/jdk repository.
The commit being backported was authored by Alexander Zuev on 25 May 2022 and was reviewed by Sergey Bylokhov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/132/head:pull/132
$ git checkout pull/132

Update a local copy of the PR:
$ git checkout pull/132
$ git pull https://git.openjdk.org/jdk8u-dev pull/132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 132

View PR using the GUI difftool:
$ git pr show -t 132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/132.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ebfa27b9f06aee8ceceabc564a78a351903ce9a1 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 10, 2022
@mrserb
Copy link
Member Author

mrserb commented Oct 10, 2022

/clean The backport is clean, only the paths are changed.

@mrserb mrserb marked this pull request as ready for review October 10, 2022 02:48
@openjdk openjdk bot added rfr Pull request is ready for review clean labels Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Dec 1, 2022

leave open

@mrserb
Copy link
Member Author

mrserb commented Dec 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit d13b813.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 2abc206: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 72269ee: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • a983a00: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 4388fa8: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • 21a1236: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
  • 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • ... and 33 more: https://git.openjdk.org/jdk8u-dev/compare/f04ad96cf53385c9f8aa071a4167ad7790cb8466...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@mrserb Pushed as commit d13b813.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8284690 branch December 6, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant