8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

[caojoshua]

Parity with Oracle. This patch is applied on top of #140. Does not apply cleanly, mostly due to surrounding context missing from the following:

• https://bugs.openjdk.org/browse/JDK-8210039 (don't think there are plans to backport this to JDK8)
• https://bugs.openjdk.org/browse/JDK-8159690 (open issue to backport this to 8, but has not been active for >1 year. might get backported)

Only one serious conflict. We cannot use

private static int wheelSign = Platform.isOSX() ? -1 : 1;

Since https://bugs.openjdk.org/browse/JDK-8210039 is missing in JDK8, we don't have

import jdk.test.lib.Platform;

Alternatively, I use the old code to get OS:

private static int wheelSign = OSInfo.getOSType().equals(OSInfo.OSType.MACOSX) ? -1 : 1;

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to f144ec00

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/jdk8u-dev pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/141.diff

[bridgekeeper]

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into pr/140 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (df904813)
• 01: Full - Incremental (f144ec00)
• 00: Full (f144ec00)

[phohensee]

Lgtm.

[phohensee]

Tagged the JBS issue.

[phohensee]

Consider backporting JDK-8210039. It has been backported to 11u in order to make subsequent backports easier. Same for 8u.

[bridgekeeper]

@caojoshua This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[caojoshua]

ping so the PR is still active. waiting on jdk-8u-fix-yes label

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8129827
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version df90481) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 91d8b89.

[openjdk]

@phohensee @caojoshua Pushed as commit 91d8b89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.