6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

[caojoshua]

Passes jdk/test/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java on my Windows machine. Not a clean backport due to:

• fix file paths
• affected test not included in ProblemList.txt in JDK8. No change required in ProblemList.txt
• conflict in copyright year

Rest is clean.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/145/head:pull/145
$ git checkout pull/145

Update a local copy of the PR:
$ git checkout pull/145
$ git pull https://git.openjdk.org/jdk8u-dev pull/145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 145

View PR using the GUI difftool:
$ git pr show -t 145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/145.diff

[bridgekeeper]

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (aabda946)

[caojoshua]

Windows tier1 failure is unrelated to this change.

[phohensee]

Lgtm, but please check the windows-x64 test failure: com/sun/jdi/DoubleAgentTest.java

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 4388fa8: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
• 21a1236: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
• c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
• 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
• 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
• fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
• 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
• 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
• 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
• ... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/5b5e548fba1073a1f87df3c71f0d09b63e033ced...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[phohensee]

And I see you've already checked, so all good. :) Tagged JBS issue.

[zzambers]

@caojoshua @phohensee, There was a problem with com/sun/jdi/DoubleAgentTest.java test being unreliable. Problem was already addressed by backport [1].

[1] #143

[bridgekeeper]

@caojoshua This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[caojoshua]

waiting on jdk8u-fix-yes tag

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version aabda94) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit a983a00.
Since your change was applied there have been 54 commits pushed to the master branch:

• 4388fa8: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
• 21a1236: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
• c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
• 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
• 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
• fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
• 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
• 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
• 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
• ... and 44 more: https://git.openjdk.org/jdk8u-dev/compare/5b5e548fba1073a1f87df3c71f0d09b63e033ced...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @caojoshua Pushed as commit a983a00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.