8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

[jmtd]

This is a backport of 8278951 to jdk8u-dev as part of the cgroups v2 backport initiative.

Dependent PRs are in use.

It was clean (modulo path shuffles). The use of log_trace needed adjusting for jdk8u-dev.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/155/head:pull/155
$ git checkout pull/155

Update a local copy of the PR:
$ git checkout pull/155
$ git pull https://git.openjdk.org/jdk8u-dev pull/155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 155

View PR using the GUI difftool:
$ git pr show -t 155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/155.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/136 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full (ec7a9cf3)
• 03: Full (13762a7e)
• 02: Full - Incremental (7fc8633b)
• 01: Full - Incremental (e6c38804)
• 00: Full (bfc817ed)

[jerboaa]

While this backport likely does no harm, PlainRead.java test mentioned in the bug got introduced with JDK-8197408, which is not in 8u. We should add that first before adding a "fix" for that test ;-) Note: we seem to have most of the changes of JDK-8197408 already in 8u.

[jmtd]

I've started a backport of the pre-requisite 8197408 (https://github.com/jmtd/jdk8u-dev/tree/8197408-jdk8u-dev) but it's not quite finished. It should slot into this sequence between this PR and its current parent (8239559 / pr/136).

As a reminder to myself, once I raise the PR for 8197408 I should /add 8198833

[jmtd]

Same test behaviour as the parent PR: passes on cgroups v1, fails on v2.

[jerboaa]

LGTM.

[openjdk-notifier]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[bridgekeeper]

@jmtd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

Keep open, please.

[openjdk]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8278951-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

@jmtd This needs a rebase onto latest master, please. Thanks! We cannot merge as is.

[openjdk]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[jerboaa]

Looks good. Feel free to integrate and then rebase #157. Thanks!

[jmtd]

/integrate

[openjdk]

Going to push as commit 5b01ebb.

[openjdk]

@jmtd Pushed as commit 5b01ebb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.