Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 #156

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 4, 2022

Clean backport from 11u which helps testing of cgroups v2 work.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jdk8u-dev pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/156.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1719c0cc12e094856955c2a3294521b79b17ba7c 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 4, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 4, 2022

Marking as clean on the basis that the 11u backport also didn't include the problem list (it was never problem listed on 8u).

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 4, 2022

/clean

@openjdk openjdk bot added the clean label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@jerboaa This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit 01f7d1e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
  • fb98418: 8295915: Problemlist compiler/rtm failures specific to 8u
  • 2cd66fb: 8270344: Session resumption errors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@jerboaa Pushed as commit 01f7d1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant