Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7124218: [TEST_BUG] [macosx] Space should select cell in the JTable #160

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 8, 2022

Backport of 2e94af3f3d7010e89852721d1fda7a226e8ffb6c
JDK-7124218 [TEST_BUG] [macosx] Space should select cell in the JTable

Clean backport.
Test expectedly fails during manual run, it is fixed by upcoming backport for JDK-8233551 #162


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7124218: [TEST_BUG] [macosx] Space should select cell in the JTable

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk8u-dev pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/160.diff

Sorry, something went wrong.

Reviewed-by: rchamyal, alexsch
(cherry picked from commit 2e94af3f3d7010e89852721d1fda7a226e8ffb6c)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2e94af3f3d7010e89852721d1fda7a226e8ffb6c 7124218: [TEST_BUG] [macosx] Space should select cell in the JTable Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7124218: [TEST_BUG] [macosx] Space should select cell in the JTable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
  • 01f7d1e: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
  • c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
  • fb98418: 8295915: Problemlist compiler/rtm failures specific to 8u
  • 2cd66fb: 8270344: Session resumption errors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@Rudometov
Your change (at version abd929e) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit 0f9095f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 6e563e5: 8159720: Failure of C2 compilation with tiered prevents some C1 compilations
  • 01f7d1e: 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137
  • c605aa3: 8296555: Enable hotspot/tier1 for 64-bit builds in GHA for 8u
  • fb98418: 8295915: Problemlist compiler/rtm failures specific to 8u
  • 2cd66fb: 8270344: Session resumption errors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@phohensee @Rudometov Pushed as commit 0f9095f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 7124218 branch April 13, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants