Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284622: Update versions of some Github Actions used in JDK workflow #167

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 9, 2022

This backport fixes warnings generated in summary page of GHA tests by updating version of some actions.

Backport fixes warnings of following form:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache, actions/upload-artifact, actions/cache, actions/checkout
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Backport does not fix warnings of following form:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

These will be fixed in separate PR as backport of JDK-8295714 [1].

[1] https://bugs.openjdk.org/browse/JDK-8295714


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284622: Update versions of some Github Actions used in JDK workflow

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.org/jdk8u-dev pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/167.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61b8c91249fb4c6d594d4a0240c92e8607caf171 8284622: Update versions of some Github Actions used in JDK workflow Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 9, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284622: Update versions of some Github Actions used in JDK workflow

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2022
@zzambers
Copy link
Contributor Author

@jerboaa Thanks
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@zzambers
Your change (at version 39bb106) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 10, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

Going to push as commit 3bfde7d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2022
@openjdk openjdk bot closed this Nov 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@jerboaa @zzambers Pushed as commit 3bfde7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants