Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer #174

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 14, 2022

Adds cygwin installer caching.

Few notes:

  • Cache also added for windows-x86, which is not present on JDK 11.
  • Used actions/cache@v3 (I have already done backport updating GHA actions, out of order, before this)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/174/head:pull/174
$ git checkout pull/174

Update a local copy of the PR:
$ git checkout pull/174
$ git pull https://git.openjdk.org/jdk8u-dev pull/174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 174

View PR using the GUI difftool:
$ git pr show -t 174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/174.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 869b25975288398a1d60601daacf00a99f51cd56 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 14, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7024bf0: 8296959: Fix hotspot shell tests of 8u on multilib systems

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@zzambers
Copy link
Contributor Author

@jerboaa Thanks
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@zzambers
Your change (at version e9e25e3) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 15, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit 6849667.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7024bf0: 8296959: Fix hotspot shell tests of 8u on multilib systems

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@jerboaa @zzambers Pushed as commit 6849667.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants