8266391: Replace use of reflection in jdk.internal.platform.Metrics

[jmtd]

A clean backport of 8266391 for jdk8u-dev as part of cgroups v2 support.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8266391: Replace use of reflection in jdk.internal.platform.Metrics

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/177/head:pull/177
$ git checkout pull/177

Update a local copy of the PR:
$ git checkout pull/177
$ git pull https://git.openjdk.org/jdk8u-dev pull/177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 177

View PR using the GUI difftool:
$ git pr show -t 177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/177.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/176 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (ce47b635)
• 01: Full - Incremental (86708c07)
• 00: Full (d458c605)

[jerboaa]

@jmtd Clean backport but breaks the macosx build. I think we need another null returning SystemMetrics class in jdk/src/macosx/classes folder.

[jerboaa]

Looks good.

[bridgekeeper]

@jmtd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

Keep open, please.

[jerboaa]

@jmtd Please rebase once #176 is integrated. Thanks.

[openjdk]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8266391-jdk8u-dev
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266391: Replace use of reflection in jdk.internal.platform.Metrics

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Looks good. Bug is approved. Feel free to integrate. After, please rebase #178 Thanks!

[jmtd]

/integrate

[openjdk]

Going to push as commit 99ff02e.

[openjdk]

@jmtd Pushed as commit 99ff02e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.