8292083: Detected container memory limit may exceed physical machine memory

[jmtd]

This is a backport of 8292083 for jdk8u-dev cgroups v2 support. It's not clean: context issues, replace the use of some log_debug and log_trace, and an adjustment to Asserts class location for hotspot tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292083: Detected container memory limit may exceed physical machine memory

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/180/head:pull/180
$ git checkout pull/180

Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.org/jdk8u-dev pull/180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 180

View PR using the GUI difftool:
$ git pr show -t 180

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/180.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/179 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jmtd]

The test builds and runs for me, and currently fails on my cgroup v2 system with

JavaTest Message: Test threw exception: java.lang.RuntimeException: 'OperatingSystemMXBean.getTotalSwapSpaceSize: [0-9]+' missing from stdout/stderr 

the relevant log line is reporting a negative value

OperatingSystemMXBean.getTotalSwapSpaceSize: -52428800

I will investigate further

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (d2a41ed8)
• 01: Full (86c67cf3)
• 00: Full (f9404e37)

[jerboaa]

-52428800

I cannot reproduce on my cg v2 system. Is this a system with swapaccount=0?

[jmtd]

The test runs in a oraclelinux:7.6 container which has glibc 2.17, versus my build machine which has 2.33, so I can't run it as-is. I'd previously aliased the name oraclelinux:7.6 to something with a matching ABI (an Ubuntu image iirc) which explains the discrepancy here.

I'd made a mental note in the past to raise the issue of what was a reasonable baseline libc ABI for jdk8u-dev, and look at backports that change the base image for the tests (I don't think 11u or newer are using oraclelinux:7.6 but ICBW)

If you can run the test and it passes, I'm satisfied :)

[jmtd]

…and running CheckOperatingSystemMXBean locally (not through jtreg, not in the oraclelinux:7.6 container) I see a reasonable value

OperatingSystemMXBean.getTotalSwapSpaceSize: 1023406080

[jerboaa]

The test runs in a oraclelinux:7.6 container which has glibc 2.17, versus my build machine which has 2.33, so I can't run it as-is. I'd previously aliased the name oraclelinux:7.6 to something with a matching ABI (an Ubuntu image iirc) which explains the discrepancy here.

Ugh. I'd recommend running tests with -Djdk.test.docker.image.name=<base-image> and -Djdk.test.docker.image.version=<image-version> that matches the JDK build you've done. For example on F37 I use -Djdk.test.docker.image.name=fedora -Djdk.test.docker.image.version=37

I'm surprised this works for you at all ;-)

[jerboaa]

Looks good to me.

Aside: @jmtd Could you please ensure the SystemMetrics fix for macosx of #177 gets into the depending PRs so that we get better GHA results. Thanks!

[jmtd]

Aside: @jmtd Could you please ensure the SystemMetrics fix for macosx of #177 gets into the depending PRs so that we get better GHA results. Thanks!

Sure, I've rebased PR's 178, 179 and 180. I think the GitHub view will look askew until the PR/xx branches are updated (by openjdk-bot?)

[openjdk-notifier]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[bridgekeeper]

@jmtd This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@jmtd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292083: Detected container memory limit may exceed physical machine memory

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Looks fine.

[jmtd]

/integrate

[openjdk]

Going to push as commit b4ef3d3.
Since your change was applied there has been 1 commit pushed to the master branch:

• 78cdc41: 8234484: Add ability to configure third port for remote JMX

Your commit was automatically rebased without conflicts.

[openjdk]

@jmtd Pushed as commit b4ef3d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.