8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows

[zzambers]

Test hotspot/test/runtime/NMT/HugeArenaTracking.java (from hotspot/tier1) currently fails on Windows x86. This backport fixes this test to only run on 64-bit archs.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.org/jdk8u-dev pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/182.diff

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (d513aeb6)
• 00: Full (b700a30f)

[jerboaa]

I don't think this has any effect on JDK 8. AFAIK, vm.bits is being set in JDK 11+ via test/jtreg-ext/requires/VMProps.java which isn't available in JDK 8. Have you tested this works?

I think something like this would be suitable here:

if (!Platform.is64Bit()) {
   System.out.println("Test requires 64 bits. Skipping...");
   return;
}

[zzambers]

Oh, you are right (not supported on JDK 8). I ran tests with 32-bit OSes enabled [1] and failure there disappeared, so I considered it working. I haven't realized test was also excluded on 64-bits. (condition was basically treated as always false) Nice find, I'll fix it. Thanks

[1] https://github.com/zzambers/jdk8u-dev/actions/runs/3471605048/jobs/5802167187

[zzambers]

But that reminds me, when I doing this backport, I was actually wondering if it is supported on 8, so I grepped jdk8u-dev repo to see if there is some other tests doing this. There is one [2]. And it is indeed also skipped everywhere. So one more test to be fixed was discovered... :)

[2]

jdk8u-dev/hotspot/test/runtime/Metaspace/MaxMetaspaceSizeTest.java

Line 29 in 7ae002c

* @requires vm.bits == "64"

[zzambers]

Fixed. Tested with 32-bit testing enabled. Passes. (Skipped on 32-bits, no longer skipped on 64-bits.)

https://github.com/zzambers/jdk8u-dev/actions/runs/3482910658

[jerboaa]

LGTM.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241086: Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
• b98d485: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
• 7ae002c: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zzambers]

@jerboaa thanks for the review
/integrate

[openjdk]

@zzambers
Your change (at version d513aeb) is now ready to be sponsored by a Committer.

[zzambers]

Oh, it does not yet have jdk8u-fix-yes (will need before sponsor)

[jerboaa]

/sponsor

[openjdk]

Going to push as commit da0c382.
Since your change was applied there have been 4 commits pushed to the master branch:

• 91d8b89: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 9cb8752: 8079255: [TEST_BUG] [macosx] Test closed/java/awt/Robot/RobotWheelTest/RobotWheelTest fails for Mac only
• b98d485: 8197859: VS2017 Complains about UINTPTR_MAX definition in globalDefinitions_VisCPP.hpp
• 7ae002c: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @zzambers Pushed as commit da0c382.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.