Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing #189

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Nov 21, 2022

I request the backport for parity with Oracle JDK 8. The patch applies clean. This backport is only a test change and fixes the test failure.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/189/head:pull/189
$ git checkout pull/189

Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk8u-dev pull/189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 189

View PR using the GUI difftool:
$ git pr show -t 189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/189.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6ea69c06aca7f013e26596cebd039960c5b4d34 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 21, 2022
@theaoqi theaoqi marked this pull request as ready for review November 21, 2022 16:03
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@theaoqi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
  • 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
  • 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
  • e9acfce: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022
@theaoqi
Copy link
Member Author

theaoqi commented Dec 5, 2022

I see jdk8u-fix-yes.

@theaoqi
Copy link
Member Author

theaoqi commented Dec 5, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@theaoqi
Your change (at version d89e5e1) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 5, 2022

Please enable testing on your fork going forward.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 5, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

Going to push as commit 21a1236.
Since your change was applied there have been 17 commits pushed to the master branch:

  • c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
  • 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
  • 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
  • e9acfce: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/91d8b89ab976a8c25484da23ded6cdbb86f7b1e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2022
@openjdk openjdk bot closed this Dec 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@jerboaa @theaoqi Pushed as commit 21a1236.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi
Copy link
Member Author

theaoqi commented Dec 6, 2022

Thanks, @jerboaa ! I have realized GHA of my fork is disabled after the PR is created and I have enabled it, but I don't know how to trigger it manually. It will work next time:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants